Optimize cast(JSON as ROW) #9449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56014538 |
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 11, 2024
Summary: boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii. With this optimization a query that's heavy on this cast runs 3x faster. Differential Revision: D56014538
mbasmanova
force-pushed
the
export-D56014538
branch
from
76f1202 to
0c8f7a3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56014538 |
Yuhta
reviewed
Apr 11, 2024
| // boost::algorithm::to_lower is very slow. Use much faster | ||
| // folly::toLowerAscii if possible. | ||
| if (allFieldsAreAscii) { | ||
| folly::toLowerAscii(lowerCaseKey); |
There was a problem hiding this comment.
Is toLowerAscii safe to be called on non-ascii input? If not we may need to check if lowerCaseKey is ascii as well
There was a problem hiding this comment.
I think it is: "Leaves all other characters unchanged, including those with the 0x80 bit set."
/**
* Convert ascii to lowercase, in-place.
*
* Leaves all other characters unchanged, including those with the 0x80
* bit set.
* @param str String to convert
* @param length Length of str, in bytes
*/
void toLowerAscii(char* str, size_t length);
inline void toLowerAscii(std::string& str) {
// str[0] is legal also if the string is empty.
toLowerAscii(&str[0], str.size());
}
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 11, 2024
Summary:
boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii.
With this optimization a query that's heavy on this cast runs 3x faster.
{F1484171823}
Differential Revision: D56014538
mbasmanova
force-pushed
the
export-D56014538
branch
from
0c8f7a3 to
65e0e6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56014538 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 11, 2024
Summary:
boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii.
With this optimization a query that's heavy on this cast runs 3x faster.
{F1484171823}
Differential Revision: D56014538
mbasmanova
force-pushed
the
export-D56014538
branch
from
65e0e6e to
8aaf584
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56014538 |
Yuhta
approved these changes
Apr 11, 2024
xiaoxmeng
approved these changes
Apr 11, 2024
| @@ -38,6 +38,17 @@ namespace facebook::velox { | |||
|
|
|||
| namespace { | |||
|
|
|||
| bool isAscii(const std::string& str) { | |||
There was a problem hiding this comment.
nit: shall we consider to put this into some common utility like common/base/String.h or StrUtil.h. This seems to be general function. Thanks!
There was a problem hiding this comment.
Let me switch to existing functions::stringCore::isAscii from velox/functions/lib/string/StringCore.h
| bool allFieldsAreAscii = true; | ||
| const auto size = rowType.size(); | ||
| for (auto i = 0; i < size; ++i) { | ||
| allFieldsAreAscii &= isAscii(rowType.nameOf(i)); |
There was a problem hiding this comment.
nit: can we break out of the loop on the first non-ascii field name?
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 11, 2024
Summary:
boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii.
With this optimization a query that's heavy on this cast runs 3x faster.
{F1484171823}
Reviewed By: xiaoxmeng, Yuhta
Differential Revision: D56014538
mbasmanova
force-pushed
the
export-D56014538
branch
from
8aaf584 to
4608fb4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56014538 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 11, 2024
Summary:
boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii.
With this optimization a query that's heavy on this cast runs 3x faster.
{F1484171823}
Reviewed By: xiaoxmeng, Yuhta
Differential Revision: D56014538
mbasmanova
force-pushed
the
export-D56014538
branch
from
4608fb4 to
f0fe19c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56014538 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 11, 2024
Summary:
boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii.
With this optimization a query that's heavy on this cast runs 3x faster.
{F1484171823}
Reviewed By: xiaoxmeng, Yuhta
Differential Revision: D56014538
mbasmanova
force-pushed
the
export-D56014538
branch
from
f0fe19c to
1a29eab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56014538 |
Summary: CAST(JSON as ROW(ARRAY()) used to fail with ``` OUT_OF_ORDER_ITERATION: Objects and arrays can only be iterated when they are first encountered. ``` According to simdjson documentation, https://github.com/simdjson/simdjson/blob/master/doc/basics.md, it is not allowed to store object values for later processing. These must be consumed or copied before proceeding. Also, fixed behavior when JSON object contains duplicate keys. Presto throws, but previous implementation used to allow duplicates. Also, fix the test to actually verify JSON objects with mixed case keys. Reviewed By: xiaoxmeng, Yuhta Differential Revision: D56013293
Summary:
boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii.
With this optimization a query that's heavy on this cast runs 3x faster.
{F1484171823}
Reviewed By: xiaoxmeng, Yuhta
Differential Revision: D56014538
mbasmanova
force-pushed
the
export-D56014538
branch
from
1a29eab to
9124213
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56014538 |
|
This pull request has been merged in efb0213. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
yanngyoung
pushed a commit
to yanngyoung/velox
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: facebookincubator#9449 boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii. With this optimization a query that's heavy on this cast runs 3x faster. {F1484171823} Reviewed By: xiaoxmeng, Yuhta Differential Revision: D56014538 fbshipit-source-id: cedfb5f58b59f29ce02344d12fdd79b2fe8fbb21
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9449 boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii. With this optimization a query that's heavy on this cast runs 3x faster. {F1484171823} Reviewed By: xiaoxmeng, Yuhta Differential Revision: D56014538 fbshipit-source-id: cedfb5f58b59f29ce02344d12fdd79b2fe8fbb21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
boost::algorithm::to_lower is very high on the profile. In most cases field names are all-ASCII, hence, we can use more efficient folly::toLowerAscii.
With this optimization a query that's heavy on this cast runs 3x faster.
Differential Revision: D56014538