Upgrade simdjson to 3.8.0 (from 3.2.0) #9456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D56031937 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 11, 2024
Summary: [simdjson] third-party library import Reviewed By: Yuhta Differential Revision: D56031937
mbasmanova
force-pushed
the
export-D56031937
branch
from
e9943d7 to
f29a939
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56031937 |
mbasmanova
changed the title
kgpai
reviewed
Apr 11, 2024
| @@ -39,6 +39,7 @@ by Velox. See details on bundling below. | |||
| | fbthrift | v2024.04.01.00 | No | | |||
| | DuckDB (testing) | 0.8.1 | Yes | | |||
| | cpr (testing) | 1.10.15 | Yes | | |||
| | simdjson | 3.8.0 | Yes | | |||
There was a problem hiding this comment.
I think simdjson already exists in the list above.
There was a problem hiding this comment.
That's right. Let me fix.
|
CC: @PHILO-HE |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 11, 2024
Summary: [simdjson] third-party library import Reviewed By: Yuhta Differential Revision: D56031937
mbasmanova
force-pushed
the
export-D56031937
branch
from
f29a939 to
9b9672c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56031937 |
Yuhta
approved these changes
Apr 11, 2024
Summary: [simdjson] third-party library import Reviewed By: Yuhta Differential Revision: D56031937
mbasmanova
force-pushed
the
export-D56031937
branch
from
9b9672c to
8822043
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56031937 |
assignUser
approved these changes
Apr 11, 2024
|
@mbasmanova, it is good to directly upgrade to this version. Thanks! |
|
This pull request has been merged in 83f5eed. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
yanngyoung
pushed a commit
to yanngyoung/velox
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: facebookincubator#9456 [simdjson] third-party library import Reviewed By: Yuhta Differential Revision: D56031937 fbshipit-source-id: 6cf5c5df865e001540cdee579a5fcd33baa7a0e0
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9456 [simdjson] third-party library import Reviewed By: Yuhta Differential Revision: D56031937 fbshipit-source-id: 6cf5c5df865e001540cdee579a5fcd33baa7a0e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: [simdjson] third-party library import
Reviewed By: Yuhta
Differential Revision: D56031937