Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for all the tasks to be deleted before reset memory system #9458

Closed
wants to merge 1 commit into from

Conversation

xiaoxmeng
Copy link
Contributor

No description provided.

@xiaoxmeng xiaoxmeng requested a review from tanjialiang April 11, 2024 22:59
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2024
@xiaoxmeng xiaoxmeng requested a review from mbasmanova April 11, 2024 22:59
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 6d43fa2
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66187707283713000832ae2a

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xiaoxmeng xiaoxmeng marked this pull request as ready for review April 11, 2024 22:59
Copy link
Contributor

@tanjialiang tanjialiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…bookincubator#9458)

Summary: Pull Request resolved: facebookincubator#9458

Reviewed By: tanjialiang

Differential Revision: D56041868

Pulled By: xiaoxmeng
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56041868

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in 4b0fd74.

Copy link

Conbench analyzed the 1 benchmark run on commit 4b0fd740.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

yanngyoung pushed a commit to yanngyoung/velox that referenced this pull request Apr 12, 2024
…bookincubator#9458)

Summary: Pull Request resolved: facebookincubator#9458

Reviewed By: tanjialiang

Differential Revision: D56041868

Pulled By: xiaoxmeng

fbshipit-source-id: 92cad676014a612abdfe60501465cc3e196252d1
@xiaoxmeng xiaoxmeng deleted the crash branch April 12, 2024 04:17
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Jun 7, 2024
…bookincubator#9458)

Summary: Pull Request resolved: facebookincubator#9458

Reviewed By: tanjialiang

Differential Revision: D56041868

Pulled By: xiaoxmeng

fbshipit-source-id: 92cad676014a612abdfe60501465cc3e196252d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants