Fix flaky spill stats check in aggregation test #9459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
force-pushed
the
flaky
branch
2 times, most recently
from
1fa1ca3 to
e6971b9
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mbasmanova
approved these changes
Apr 11, 2024
The flaky is due to spill check condition is fragile which is based on whether we have received more than one input at partial aggregation. We shall change to final aggregation and given we have four drivers so it is not guarantee one aggregation has received more than one input row. Since we have recorded the spill injection count, then we just rely on this to check spill stats. This PR also restrict the case that we trigger spill for output memory reservation by checking if table is null or empty
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 2b2ef52. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: The flaky is due to spill check condition is fragile which is based on whether we have received more than one input at partial aggregation. We shall change to final aggregation and given we have four drivers so it is not guarantee one aggregation has received more than one input row. Since we have recorded the spill injection count, then we just rely on this to check spill stats. This PR also restrict the case that we trigger spill for output memory reservation by checking if table is null or empty Pull Request resolved: facebookincubator#9459 Reviewed By: mbasmanova Differential Revision: D56043610 Pulled By: xiaoxmeng fbshipit-source-id: 4deaec31e7097a4aa13b695e515ac6baecc4f3ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flaky is due to spill check condition is fragile which is based on whether we have received
more than one input at partial aggregation. We shall change to final aggregation and given we
have four drivers so it is not guarantee one aggregation has received more than one input row.
Since we have recorded the spill injection count, then we just rely on this to check spill stats.
This PR also restrict the case that we trigger spill for output memory reservation by checking
if table is null or empty