Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check compatibility #9507

Closed

Conversation

DanielMunozT
Copy link
Member

Summary: Check if all builds pass in velox for std::atomic::wait() (C++ 20)

Differential Revision: D56214917

Daniel Munoz added 2 commits April 16, 2024 15:03
Summary:

A prefetching algorithm for UnitLoader (that isn't in OSS layer yet, but I'll move it soon) emits a "no more IO" signal when the last IO was done for the reader tree, so we can start asynchronously prefetching the next file.

I need that signal to be emitted only once for a reader tree, that is, when the last reader did its last IO.

This helper class will do the work.

Differential Revision: D56210938
Summary: Check if all builds pass in velox for std::atomic::wait() (C++ 20)

Differential Revision: D56214917
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56214917

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit e2debb9
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/661ef5bb4cf17600086ba075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants