Fix the path to copy hive.properties from scripts #9967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
I notice failures of fuzzer test after merging #9759 due to wrong file path |
xiaoxmeng
approved these changes
May 29, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
assignUser
approved these changes
May 29, 2024
kgpai
approved these changes
May 29, 2024
|
@xiaoxmeng merged this pull request in 4d4160c. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
Thank you for the quick response! |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…9967) Summary: hive.properties has been moved to scripts/presto/etc. We need to update the path to copy it from. Pull Request resolved: facebookincubator#9967 Reviewed By: kgpai Differential Revision: D57894974 Pulled By: xiaoxmeng fbshipit-source-id: fb321a78cc46567d5053acb2a6a37d017f2b5d9a
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…9967) Summary: hive.properties has been moved to scripts/presto/etc. We need to update the path to copy it from. Pull Request resolved: facebookincubator#9967 Reviewed By: kgpai Differential Revision: D57894974 Pulled By: xiaoxmeng fbshipit-source-id: fb321a78cc46567d5053acb2a6a37d017f2b5d9a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hive.properties has been moved to scripts/presto/etc. We need to update the
path to copy it from.