-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add vanilla and optimized cpu device to detectron #596
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@jgong5 Good to see other people are trying to solve big issues of the Detectron! Does this mean with this PR merged we can already run Mask R-CNN models and Keypoint Mask R-CNN models ? Or some operators are still missing from PyTorch/Caffe2 ? |
@gadcam The accompanying PR for PyTorch/Caffe2 is here: We validated the accuracy of Faster-RCNN and Mask-RCNN with ResNet-50/FPN backbone. |
@gadcam Any comments? Possible to merge the changes? We will PR further optimizations to PyTorch and Detectron repo. But this PR would be the baseline. |
My comments here have no special value and I have no way to influence the merge decisions, I am a contributor like you :) I think you should ping @rbgirshick and @ir413 which are the maintainers. |
@rbgirshick @ir413 Any comments? |
@rbgirshick - can you take a look and confirm? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I would like to use this PR to initiate the support of CPU device paths in detectron. Changes are made minimal in this PR to ask the advice from the community a good integration approach to follow. There are two major changes:
Renaming the hard-coded GpuNameScope/CudaScope to more general names might be a more elegant approach but this would require changes of many places in detectron code. Any suggestions?