Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GS usages to new module location #623

Closed
wants to merge 1 commit into from

Conversation

ItsMrLin
Copy link
Contributor

@ItsMrLin ItsMrLin commented Feb 5, 2025

Summary:
Removing the following old files from ax/modelbridge/ in favor of the new ax/generation_strategy directory.

best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py

Differential Revision: D68645075

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68645075

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68645075

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68645075

ItsMrLin added a commit to ItsMrLin/aepsych that referenced this pull request Feb 5, 2025
Summary:
Pull Request resolved: facebookresearch#623

X-link: facebook/Ax#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Feb 5, 2025
Summary:
X-link: facebookresearch/aepsych#623

Pull Request resolved: facebook#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68645075

ItsMrLin added a commit to ItsMrLin/aepsych that referenced this pull request Feb 6, 2025
Summary:
Pull Request resolved: facebookresearch#623

X-link: facebook/Ax#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Feb 6, 2025
Summary:
X-link: facebookresearch/aepsych#623

Pull Request resolved: facebook#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Feb 6, 2025
Summary:
X-link: facebookresearch/aepsych#623

Pull Request resolved: facebook#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68645075

ItsMrLin added a commit to ItsMrLin/aepsych that referenced this pull request Feb 6, 2025
Summary:
Pull Request resolved: facebookresearch#623

X-link: facebook/Ax#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68645075

ItsMrLin added a commit to ItsMrLin/aepsych that referenced this pull request Feb 6, 2025
Summary:
Pull Request resolved: facebookresearch#623

X-link: facebook/Ax#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Feb 6, 2025
Summary:
X-link: facebookresearch/aepsych#623

Pull Request resolved: facebook#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68645075

ItsMrLin added a commit to ItsMrLin/aepsych that referenced this pull request Feb 6, 2025
Summary:
Pull Request resolved: facebookresearch#623

X-link: facebook/Ax#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Feb 6, 2025
Summary:
X-link: facebookresearch/aepsych#623

Pull Request resolved: facebook#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Feb 7, 2025
Summary:
X-link: facebookresearch/aepsych#623

Pull Request resolved: facebook#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68645075

ItsMrLin added a commit to ItsMrLin/aepsych that referenced this pull request Feb 7, 2025
Summary:
Pull Request resolved: facebookresearch#623

X-link: facebook/Ax#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
Summary:
Pull Request resolved: facebookresearch#623

X-link: facebook/Ax#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Feb 7, 2025
Summary:
X-link: facebookresearch/aepsych#623

Pull Request resolved: facebook#3311

Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Reviewed By: saitcakmak

Differential Revision: D68645075
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68645075

facebook-github-bot pushed a commit to facebookresearch/Kats that referenced this pull request Feb 7, 2025
Summary:
X-link: facebookresearch/aepsych#623

X-link: facebook/Ax#3311

In this diff, we migrated everything in the codebase to use `ax.generation_strategy.xxx` instead of the old `ax.modelbridge.xxx` for the following files.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Meta: In the previous diff D68720587 we moved these files from `ax/modelbridge/` to the new `ax/generation_strategy` directory, but all applications are still using/importing from the `modelbridge` folder.

Reviewed By: saitcakmak

Differential Revision: D68645075

fbshipit-source-id: e724c73e3733a04d6c5e8fa31284473095451e75
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6f0b90a.

facebook-github-bot pushed a commit to facebook/Ax that referenced this pull request Feb 7, 2025
Summary:
X-link: facebookresearch/aepsych#623

Pull Request resolved: #3311

In this diff, we migrated everything in the codebase to use `ax.generation_strategy.xxx` instead of the old `ax.modelbridge.xxx` for the following files.

```
best_model_selector.py
dispatch_utils.py
external_generation_node.py
generation_node_input_constructors.py
generation_node.py
generation_strategy.py
model_spec.py
transition_criterion.py
```

Meta: In the previous diff D68720587 we moved these files from `ax/modelbridge/` to the new `ax/generation_strategy` directory, but all applications are still using/importing from the `modelbridge` folder.

Reviewed By: saitcakmak

Differential Revision: D68645075

fbshipit-source-id: e724c73e3733a04d6c5e8fa31284473095451e75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants