-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate GS usages to new module location #623
Conversation
This pull request was exported from Phabricator. Differential Revision: D68645075 |
This pull request was exported from Phabricator. Differential Revision: D68645075 |
71cc67c
to
ddf8543
Compare
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ddf8543
to
c4d03a7
Compare
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
This pull request was exported from Phabricator. Differential Revision: D68645075 |
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
c4d03a7
to
3e388fa
Compare
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
This pull request was exported from Phabricator. Differential Revision: D68645075 |
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
3e388fa
to
d8219c1
Compare
This pull request was exported from Phabricator. Differential Revision: D68645075 |
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
d8219c1
to
1be2f04
Compare
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
This pull request was exported from Phabricator. Differential Revision: D68645075 |
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
1be2f04
to
0ce9e05
Compare
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
This pull request was exported from Phabricator. Differential Revision: D68645075 |
0ce9e05
to
a92856e
Compare
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
This pull request was exported from Phabricator. Differential Revision: D68645075 |
a92856e
to
7c95ad1
Compare
Summary: X-link: facebookresearch/aepsych#623 X-link: facebook/Ax#3311 In this diff, we migrated everything in the codebase to use `ax.generation_strategy.xxx` instead of the old `ax.modelbridge.xxx` for the following files. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Meta: In the previous diff D68720587 we moved these files from `ax/modelbridge/` to the new `ax/generation_strategy` directory, but all applications are still using/importing from the `modelbridge` folder. Reviewed By: saitcakmak Differential Revision: D68645075 fbshipit-source-id: e724c73e3733a04d6c5e8fa31284473095451e75
This pull request has been merged in 6f0b90a. |
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: #3311 In this diff, we migrated everything in the codebase to use `ax.generation_strategy.xxx` instead of the old `ax.modelbridge.xxx` for the following files. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Meta: In the previous diff D68720587 we moved these files from `ax/modelbridge/` to the new `ax/generation_strategy` directory, but all applications are still using/importing from the `modelbridge` folder. Reviewed By: saitcakmak Differential Revision: D68645075 fbshipit-source-id: e724c73e3733a04d6c5e8fa31284473095451e75
Summary:
Removing the following old files from
ax/modelbridge/
in favor of the newax/generation_strategy
directory.Differential Revision: D68645075