strategy methods act on copies of models if desired #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
facebook-github-bot
added
the
CLA Signed
JasonKChow
force-pushed
the
pr632
branch
2 times, most recently
from
9363e6b to
075e40d
Compare
Summary: The server wasn't very asynchronous, so we rewrite the entirety of it to be multithreaded. Test Plan: Updated tests
Summary: To allow db to be accessible across threads, sessions need to be scoped carefully. Test Plan:
Summary: This was used inconsistently and causes problems Test Plan:
Summary: Messages are also now info so that runner can tell things are happening. Debug is saved for very verbose errors. Test Plan:
Summary: Add extra flag to strategy to allow all model-related operations to act on a copy (then save that copy if needed). Used for multi-client server. Test Plan:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add extra flag to strategy to allow all model-related operations to act on a copy (then save that copy if needed). Used for multi-client server.
Test Plan:
Stack created with Sapling. Best reviewed with ReviewStack.