Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix d2go.config #571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix d2go.config #571

wants to merge 1 commit into from

Commits on Jun 12, 2023

  1. fix d2go.config 

    Summary:
I think the main issue is that we import `reroute_config_path` from `d2go.config.config` in `__init__.py`, but it's actually in `d2go.config.utils`. After fixing this, the namespace forward also works, see `scripts/wangyanghan/autodeps_testbed/d2go_config/TARGETS`

Update all TARGETS:
```
fbgs -l "d2go/config:" | xargs printf -- '/data/sandcastle/boxes/%s\n' | xargs arc lint -a
```

For reviewers, only `.autodeps.toml` and files in `d2go/d2go/config/` and `scripts/wangyanghan/autodeps_testbed/d2go_config/` are manually changed, other files are auto modified.

Reviewed By: ajinkya-deogade

Differential Revision: D46582416

fbshipit-source-id: c801d47717e3297700a7bbd52f974653ee760826
    @facebook-github-bot
    Yanghan Wang authored and facebook-github-bot committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    5840e52 View commit details
    Browse the repository at this point in the history