Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detectron doesn't include torch as a formal dependency #5228

Open
mdvthu opened this issue Mar 2, 2024 · 1 comment
Open

Detectron doesn't include torch as a formal dependency #5228

mdvthu opened this issue Mar 2, 2024 · 1 comment

Comments

@mdvthu
Copy link

mdvthu commented Mar 2, 2024

Instructions To Reproduce the 🐛 Bug:

  1. Full runnable code or full changes you made:
cd new-python-project-requiring-detectron2
echo 'detectron2 @ git+https://github.com/facebookresearch/detectron2.git#[email protected]' >> requirements.txt
python3.10 -m venv venv
. venv/bin/activate
python -m pip install -r requirements.txt

The above will fail as torch is not already available and not installed as a dependency

Desired behavior:

If detectron2 included torch as a stated dependency, it would make fresh install more straightforward. It currently crashes without a useful error message due to the import torch statement in setup.py

This limits the usefulness of using clean virtual environments (with repeatable requirements.txt) as a manual install of pytorch is required first

@mdvthu mdvthu changed the title Please read & provide the following Detectron doesn't depend on torch Mar 2, 2024
@mdvthu mdvthu changed the title Detectron doesn't depend on torch Detectron doesn't include torch as a formal dependency Mar 2, 2024
@Programmer-RD-AI
Copy link
Contributor

An PR #5296 has been setup :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants