Fix torch dependency requirement and code formatting in setup.py #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes ensure that the torch dependency requirement is correctly specified and improve the overall code quality of the setup.py file.
facebook-github-bot
added
the
CLA Signed
|
torch seems to also be a build requirement. Adding it in setup.py as a dependency still doesn't seem to fix everything. I got detectron2 to install with [build-system]
requires = ["setuptools", "torch"]Though in addition to that it should be added in |
mostlyuseful
added a commit
to mostlyuseful/detectron2
that referenced
this pull request
Jun 20, 2024
Tried it in a fork, that was the missing piece for my setup. Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #5228 reported by @mdvthu. The changes ensure that the torch dependency requirement in the setup.py file of Detectron2 is correctly specified, aligning with actual version compatibility. Additionally, the code formatting and readability in the setup.py file have been improved for better consistency.
Before submitting this PR, I have run
dev/linter.shto ensure that the code adheres to the project's linting standards.Thank you for considering this contribution!