This repository has been archived by the owner on Nov 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 726
add log_training_trajectory option #549
Open
todpole3
wants to merge
9
commits into
opt_instruct
Choose a base branch
from
opt_instruct_training_trajectory
base: opt_instruct
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todpole3
force-pushed
the
opt_instruct_training_trajectory
branch
from
December 11, 2022 10:50
5cd7183
to
54b3e87
Compare
…taseq into opt_instruct_training_trajectory
sriniiyer
reviewed
Dec 12, 2022
@@ -418,6 +418,10 @@ def validate_and_save( | |||
and num_updates >= cfg.dataset.validate_after_updates | |||
and was_successful_step | |||
) | |||
or ( | |||
cfg.dataset.log_training_trajectory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to save? Just validate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To plot the trajectory for generation tasks as well (ROUGE); eval will be fast
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if set, evaluate and save checkpoints more frequently in early stage of training