Rewrite type exports to match runtime code #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the index.d.ts file to match the actual exported structure, which is important for compatibility with the tsconfig `moduleResolution` option being set to `Node16` or `NodeNext`, which is the recommended value for new projects. As far as I can tell this doesn't break any compatibility with existing projects that are still using the old value of `moduleResolution: Node`. It might technically break the build if anyone was using named imports of these values, but such code would fail to import at runtime anyway, so this is actually desirable.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the index.d.ts file to match the actual exported structure, which is important for compatibility with the tsconfig
moduleResolutionoption being set toNode16orNodeNext, which is the recommended value for new projects.As far as I can tell this doesn't break any compatibility with existing projects that are still using the old value of
moduleResolution: Node. It might technically break the build if anyone was using named imports of these values, but such code would fail to import at runtime anyway, so this is actually desirable.