-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1 - Persistent 3D tracer waveforms #2
Fix #1 - Persistent 3D tracer waveforms #2
Conversation
Thanks for the attempt. I'm hesitant to merge this as-is because it breaks the 3D camera movement, it feels very choppy and clears the existing geometry. Maybe we can find a different solution. |
So the simpler 3D drawing technique I was using in 0d9e9db still works: Maybe we just need to go back to basics and start over on the drawing code. I had a 3D mesh version of this that looked pretty cool but I'm not sure why it stopped drawing the faded lines. |
This is the commit that appears to have broken the drawing code on processing 3: The only big difference I see is I switched from |
Yeah, I'm a newbie at Processing 3 but it's the only solution I could figure out so far to get persistent waveforms. It creates the problem of needing to clear the background on camera movement or perspective changes. Not sure how this problem is solved usually. The There's probably a better way to do this. I'm not sure how to persist drawn 3D objects, but maybe there is a way to do 3D transforms when changing camera perspective. I'm not too familiar with the differences and 3D objects in Processing like That screenshot looks pretty good! I like the lighting and shadows effect. I was experimenting with using different
|
Just looked at the diff for 372a9cc and saw something that gave me a hunch, (maybe it's just because I don't understand yet the use of shape functions well enough). Does the order and placement of Do these need to have matching pairs of EDIT: I missed the second |
Yeah so check the docs for beginShape. I'm not sure why I changed the loop structure there. But I remember at one point I was doing each part of the mesh as a strip of triangles and switched to those wireframe lines at that commit I linked earlier. I'd say for now it's probably easiest to switch back to rendering a simpler type of mesh using triangle strip wireframes based on the working commit I linked above. |
Alright I messed with this a bit today and was able to get it working by reverting back to a more normal technique for drawing triangle strips. I am going to close this PR since I think my solution in 7f8a255 works better with a moving camera. I also switched the camera to use PeasyCam which is hopefully a bit more user- and programmer-friendly. Thanks for giving me a kick in the butt to get this fixed! |
Some simple modifications to where and how often the
background()
is redrawn can fix the draw persistence behavior 😸Not sure how to fix the blue color's brightness to behave like the original YouTube video. That is to say: There is now no difference between the 3D "scan" line and the persisted drawn trails.