feat: download shared data without auth #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorShadurin
changed the title
nugaon
requested changes
Aug 15, 2022
src/file/file.ts
Outdated
| async downloadFromSharedPod(podReference: string | EncryptedReference, fullPath: string): Promise<Data> { | ||
| assertEncryptedReference(podReference) | ||
|
|
||
| const info = await getSharedPodInfo(this.accountData.connection.bee, podReference) |
There was a problem hiding this comment.
it can be executed without authentication as it states but the first parameter of getSharedPodInfo comes from this.accountData. without authentication it should be null, shouldn't it?
There was a problem hiding this comment.
In the current implementation, it will never be null, because after the connection is created, it is stored in this instance.
src/file/file.ts
Outdated
Comment on lines
216
to
222
| const info = await this.getSharedInfo(fileReference) | ||
| const data = await downloadData( | ||
| this.accountData.connection.bee, | ||
| combine(info.meta.file_path, info.meta.file_name), | ||
| prepareEthAddress(info.source_address), | ||
| this.accountData.connection.options?.downloadOptions, | ||
| ) |
There was a problem hiding this comment.
which is really strange for me is that you only need the file path and the ethereum address of the feed owner from the info.
Even if the info lies under an encrypted reference, the data that can be downloaded by that is unenrypted.
I thought by resolving #19 these problems disappeared.
IgorShadurin
changed the title
IgorShadurin
force-pushed
the
68-download-shared-data-from-pod-without-auth
branch
from
dd2f45b to
7a20b02
Compare
IgorShadurin
force-pushed
the
68-download-shared-data-from-pod-without-auth
branch
from
7a20b02 to
b813c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #68