feat: directory uploading #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nugaon
approved these changes
Jan 17, 2023
| * @param accountData account data | ||
| * @param options upload options | ||
| */ | ||
| export async function uploadData( |
There was a problem hiding this comment.
I see you moved this function from file.ts to here, but can you elaborate for me please what is the role of the handler.ts in the service folders and according to what you distingish to put functions to the other main file like here the file.ts?
There was a problem hiding this comment.
file/file.ts, directory/directory.ts could be renamed to file/index.ts, directory/index.ts.
So, this renamed index.ts is an aggregation of all functions into functions that are available to the user. They validate user input and pass it to the method from handler.ts. handler.ts aggregates a function from utils.ts and other files.
IgorShadurin
force-pushed
the
feat/205-directory-uploading
branch
from
9f726c3 to
bedfb9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #205
Version for Node.js and browser. I failed to cover directory selection with real test. Perhaps it will be possible to cover with mocks.
Therefore, a page was created to manually test this functionality
test/manual/index.html.But the method will only work in the browser with fixes from this branch (
duplex: halffix): #151.