fix: ability to create deleted file/directory again #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nugaon
requested changes
Feb 15, 2023
nugaon
requested changes
Feb 22, 2023
IgorShadurin
force-pushed
the
192-new-upload-deleted-file-again
branch
from
ca13430 to
0ca8e75
Compare
Which doc? Readme or FIP? |
nugaon
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
LGTM!
please create new PR to update https://github.com/fairDataSociety/FIPs/blob/master/text/0061-personal-storage.md regarding the deletion
|
Added info about deletion: fairDataSociety/FIPs#70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix fixes deleting and re-uploading not only files, but also directories.
Copied FairOS mechanism for removing content. A feed containing the file's metadata is replaced with the magic word
__Fair__after deletion in order to be able to detect that the file has already been uploaded.Close #192