Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README link to Policy Report documentation #578

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix README link to Policy Report documentation #578

merged 1 commit into from
Dec 18, 2023

Conversation

brianirish
Copy link
Contributor

@brianirish brianirish commented Nov 25, 2023 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Updates the link to the policy report output documentation

@poiana poiana requested a review from alacuku November 25, 2023 01:57
@poiana
Copy link
Contributor

poiana commented Nov 25, 2023

Welcome @brianirish! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested a review from bencer November 25, 2023 01:57
@brianirish
Copy link
Contributor Author

/kind documentation

@poiana poiana added the kind/documentation Improvements or additions to documentation label Nov 25, 2023
@cpanato
Copy link
Member

cpanato commented Nov 25, 2023

Need to bump the chart version

@brianirish
Copy link
Contributor Author

Need to bump the chart version

Thanks @cpanato I've bumped the chart version. It takes a while for the test check to give a result I guess?

@Issif
Copy link
Member

Issif commented Nov 28, 2023 •
edited
Loading

You bumped the falco chart version, but not the falcosidekick. Moreover, you need to update the changelog either. Once both done, we'll allow the CI to run, cause it's your first PR, it requires a manual approval from the maintainers to run.

@poiana poiana added size/S and removed size/XS labels Nov 28, 2023
@brianirish
Copy link
Contributor Author

Thanks for the advice @Issif, I have made the appropriate changes as per your comment.

@Issif
Copy link
Member

Issif commented Nov 28, 2023

Can you remove the changed you made for the falco chart, scope your PR to falcosidekick please

@poiana poiana added size/XS and removed size/S labels Nov 30, 2023
@brianirish
Copy link
Contributor Author

@Issif Completed. Thank you!

@leogr
Copy link
Member

leogr commented Dec 18, 2023

Merge conflicts arise after merging #586

I'm going to address them, and I will approve.

PS
Thank you for this PR 🙏

@poiana poiana added the lgtm label Dec 18, 2023
@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

LGTM label has been added.

Git tree hash: c0b3ae4c7d44975b73624ec059edc1ca02c54688

@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianirish, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f77aabc into falcosecurity:master Dec 18, 2023
3 checks passed
@brianirish brianirish deleted the readme-fix-policy-report-link branch December 18, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@alacuku alacuku Awaiting requested review from alacuku

@bencer bencer Awaiting requested review from bencer

Assignees

@leogr leogr

Labels
approved dco-signoff: yes kind/documentation Improvements or additions to documentation lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brianirish @poiana @cpanato @Issif @leogr