-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add extra labeling capabilities for falco daemonset/deployment #684
Conversation
Welcome @Strigix! It looks like this is your first PR to falcosecurity/charts 🎉 |
Please, run |
@Strigix, can you bump the chart version and then run |
@alacuku I Hadn't realised it went up another version! |
hey @Strigix, could you squash your commits? Once you've done it, we are ready to merge it. |
d898fbd
to
75613fd
Compare
…ing. Signed-off-by: Strigix <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, Strigix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: eabfb6f77a0cc5479ec54e77707f10337fe5f69e
|
/kind feature
/kind chart-release
/area falco-chart
What this PR does / why we need it:
This PR adds an extra field:
controller.labels
which allows users to set extra labels for the Falco daemonset/deployment.