fix(falco): correctly mount host filesystems when driver.kind is auto #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When falco runs with kmod/module driver it needs special filesystems to be mounted from the host such /dev and /sys/module/falco. This commit ensures that we mount them in the falco container. Note that, the /sys/module/falco is now mounted as /sys/module since we do not know which kind of driver will be used. The falco folder exists under /sys/module only when the kernel module is loaded, hence it's not possible to use the /sys/module/falco hostpath when driver.kind is set to auto. Signed-off-by: Aldo Lacuku <[email protected]>
poiana
added
kind/chart-release
|
/hold |
|
/unhold |
Issif
approved these changes
Sep 11, 2024
|
LGTM label has been added. Git tree hash: 29bf5e49718825d3b529910eeb9b74268e470b0d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind chart-release
Any specific area of the project related to this PR?
What this PR does / why we need it:
When falco runs with kmod/module driver it needs special filesystems to be mounted from the host such /dev and /sys/module/falco. This commit ensures that we mount them in the falco container.
Note that, the /sys/module/falco is now mounted as /sys/module since we do not know which kind of driver will be used. The falco folder exists under /sys/module only when the kernel module is loaded, hence it's not possible to use the /sys/module/falco hostpath when driver.kind is set to auto.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist