fix: Use rules_files instead of deprecated rules_file in README.md config snippet #780
Conversation
poiana
added
kind/documentation
|
Welcome @robinlandstrom! It looks like this is your first PR to falcosecurity/charts 🎉 |
|
Hey @robinlandstrom, thanks for the PR! Please review the contribution guidelines and update your PR: https://github.com/falcosecurity/charts?tab=readme-ov-file#contributing? |
…n config snippet Using rules_file causes collision with rules_files and falco does not start ``` Tue Nov 12 14:23:17 2024: Using deprecated config key 'rules_file' (singular form). Please use new 'rules_files' config key (plural form). Error: Error reading config file (/etc/falco/falco.yaml): both 'rules_files' and 'rules_file' keys set ``` Signed-off-by: Robin Landström <[email protected]>
Signed-off-by: Robin Landström <[email protected]>
robinlandstrom
force-pushed
the
patch-1
branch
from
abaadbf to
1726d4c
Compare
|
Hey @alacuku Should look better now, sorry felt a bit silly to bump the version for a one letter change in the README. Let me know if anything else needs to be changed in the PR |
robinlandstrom
force-pushed
the
patch-1
branch
from
1726d4c to
b97aef0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, robinlandstrom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: a4775d92540185875353ac5c55339e9eb31bf205
|
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
Current snippet in chars/falco/README.md that uses
rules_filecauses collision withrules_filesand falco does not start