Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download artifacts + get-assets command #49

Closed

Conversation

shreyass-ranganatha
Copy link
Contributor

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area proposals

What this PR does / why we need it:

Adds a easier npm run get-assets option to download and setup a dev environment quickly. Utilises a separate branch to store the required assets

Which issue(s) this PR fixes:

Fixes #13

Special notes for your reviewer:

None

@poiana
Copy link
Contributor

poiana commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shreyass-ranganatha
Once this PR has been reviewed and has the lgtm label, please assign rohith-raju for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from leogr and Rohith-Raju February 13, 2024 09:36
@Rohith-Raju
Copy link
Collaborator

Rohith-Raju commented Feb 14, 2024

@shreyass-ranganatha Thank you for the PR!
I was trying out the script and ran into an error

Screenshot 2024-02-14 at 6 11 56 PM

made sure I have the updated npm-packages. Is there conflicts with the Nodejs versions?

readme.md Show resolved Hide resolved
@shreyass-ranganatha shreyass-ranganatha deleted the s3-issue#13 branch March 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate downloading falco artifacts
3 participants