Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(userspace/falco): introduce new engine_version_semver key in v… #2899

Merged
merged 1 commit into from
Nov 8, 2023
Merged

update(userspace/falco): introduce new engine_version_semver key in v… #2899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion userspace/falco/versions_info.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,12 @@ nlohmann::json falco::versions_info::as_json() const
version_info["driver_api_version"] = driver_api_version;
version_info["driver_schema_version"] = driver_schema_version;
version_info["default_driver_version"] = default_driver_version;
version_info["engine_version"] = engine_version;
// note: the 'engine_version' key below must be removed in the next major bump (0.x.y -> 1.0.0)
// the two keys are kept for existing tooling that relies on the old key
// (falcoctl will match old rules artifacts configs by using this key, and the new ones using
// the engine_version_semver key)
version_info["engine_version"] = std::to_string(FALCO_ENGINE_VERSION_MINOR);
version_info["engine_version_semver"] = engine_version;
for (const auto& pv : plugin_versions)
{
version_info["plugin_versions"][pv.first] = pv.second;
Expand Down
Loading