cleanup!(cmake): dropped bundled plugins since falcoctl takes care of everything #2997
Conversation
…everything. Signed-off-by: Federico Di Pierro <[email protected]>
|
/hold |
|
/milestone 0.37.0 |
|
Will update #2763 issue once we all agree. |
|
agree with this! but this is a breaking change so in case I would add a |
|
It is already there (at least in the release notes); will add it to title too. |
FedeDP
changed the title
FedeDP
force-pushed
the
cleanup/remove_bundled_plugins
branch
4 times, most recently
from
033737b to
4eec106
Compare
…plugin before running tests. Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
cleanup/remove_bundled_plugins
branch
from
4eec106 to
efda35a
Compare
| - name: Install needed artifacts using falcoctl | ||
| if: ${{ inputs.static == false }} | ||
| run: | | ||
| sudo mkdir -p /usr/share/falco/plugins |
There was a problem hiding this comment.
so the e2e tests now look at plugins + rules under /usr/share/falco/plugins instead of relying on the ones bundled in the tar.gz. This is possible without modification because /usr/share/falco/ and /etc/falco are the default paths, isn't it?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Since:
Completely drop plugins shipped in Falco bundle.
This way, we will have a single way to install and enable plugins (using falcoctl + updating the Falco config) for any environment where Falco is going to be installed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: