-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(falco): add json_include_message_property to have a message field without date and priority #3314
new(falco): add json_include_message_property to have a message field without date and priority #3314
Conversation
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
bc50207
to
17e45c2
Compare
false positive /unhold |
/milestone 0.39.0 |
Signed-off-by: Luca Guerra <[email protected]>
17e45c2
to
4a33e78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 72b133d9d8fc77af867fe677be4852f7987bf8b5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
There are multiple discussions (#2985) about allowing JSON output that has a field containing only the rule output. One proposal is to change the output format but that would cause breaking changes, and also several tools (including possibly Falcosidekick) rely on a specific output format so it seems too risky to do that. However, we still want the pure unfiltered rule output, so we're introducing a new field called
"message"
to do just that. You can turn on and off both theoutput
andmessage
fields from yourfalco.yaml
.Example of the difference between the two:
NOTE1: This PR is WIP because it depends on: #3308 , but it's useful to run the CI
NOTE2: I also wrote a much heavier modification to the test suite to allow this to be tested, but it involves creating sinsp events and so it's a bit messy, it'll require more discussion
Which issue(s) this PR fixes:
Fixes #2985
Special notes for your reviewer:
Does this PR introduce a user-facing change?: