Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid deprecated funcs to calculate sha256 #3442

Conversation

federico-sysdig
Copy link
Contributor

@federico-sysdig federico-sysdig commented Jan 7, 2025

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
When building Falco with recent versions of OpenSSL all SHA256_* functions are reported as being deprecated. This PR uses a set of different functions to calculate a SHA256 checksum that avoids the deprecation. The behavior is the same.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
No

NONE

Copy link

github-actions bot commented Jan 7, 2025

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@federico-sysdig federico-sysdig force-pushed the chore-avoid-deprecated-sha256-functions branch from 22a1a8f to 3f8c606 Compare January 7, 2025 16:46
@federico-sysdig
Copy link
Contributor Author

/unhold

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, federico-sysdig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jan 8, 2025

LGTM label has been added.

Git tree hash: bea2aaab74499f092088b4e2bf3cee121b7ba1b7

@poiana poiana added the approved label Jan 8, 2025
@FedeDP
Copy link
Contributor

FedeDP commented Jan 8, 2025

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Jan 8, 2025
@federico-sysdig
Copy link
Contributor Author

@incertum, may I ask you to double-check on this PR?
It's quick and I'd like to be sure that my desire to avoid functions that are deprecated in recent versions of OpenSSL is not causing disruption.

@poiana
Copy link
Contributor

poiana commented Jan 13, 2025

@Scutua: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM.

cc @LucaGuerra

/release-note-none

@poiana poiana merged commit ec2c2e8 into falcosecurity:master Jan 13, 2025
34 of 35 checks passed
@FedeDP
Copy link
Contributor

FedeDP commented Jan 13, 2025

test-dev-packages-arm64

Isn't test-dev-packages-arm64 a required check?

@leogr
Copy link
Member

leogr commented Jan 13, 2025

test-dev-packages-arm64

Isn't test-dev-packages-arm64 a required check?

not sure about that 🤔 Maybe that is due to flaky arm tests? @LucaGuerra ?

@LucaGuerra
Copy link
Contributor

Yes we had to disable that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants