fix(userspace/falco): use container_engines.cri.sockets in load_yaml #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @zayaanmoez! It looks like this is your first PR to falcosecurity/falco 🎉 |
|
/milestone 0.40.0 |
|
Great catch! Thank you! |
LucaGuerra
approved these changes
Jan 16, 2025
|
LGTM label has been added. Git tree hash: 01d5b62c2f6bb65e6537ca079b63fd5df737e6f0
|
sgaist
approved these changes
Jan 17, 2025
|
Ehy @zayaanmoez can you rebase on latest Falco master? It will fix the ci! Thank you very much! |
zayaanmoez
force-pushed
the
fix/cri_sockets_config
branch
from
43ff0ff to
72b8dd9
Compare
Signed-off-by: Zayaan Moez <[email protected]>
zayaanmoez
force-pushed
the
fix/cri_sockets_config
branch
from
72b8dd9 to
68b5c67
Compare
|
LGTM label has been added. Git tree hash: 0f674e953256617003831bf0d06cac77d31f9a66
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, zayaanmoez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Since falco 0.39.0, the cri flag is deprecated but the recommended flag
-o container_engines.cri.sockets[]=<socket_path>or the config file sockets values are not being applied since falco is trying to load the values fromcontainer_engines.cri.criWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Yes