Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg/options): do not enforce driver version to be semver, since it can also be a commit hash #367

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 6, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area library

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 6, 2023

/milestone v0.7.0

@poiana poiana added this to the v0.7.0 milestone Dec 6, 2023
@poiana poiana added the size/XS label Dec 6, 2023
…t can also be a commit hash.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP FedeDP force-pushed the fix/driver_validate branch from 0d77470 to 8d2fe99 Compare December 6, 2023 12:31
@poiana poiana added the lgtm label Dec 6, 2023
@poiana
Copy link
Contributor

poiana commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 609a8a2 into main Dec 6, 2023
12 checks passed
@poiana poiana deleted the fix/driver_validate branch December 6, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants