fix(pkg/driver): do not call FixupKernel when building drivers. #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone v0.7.0 |
FedeDP
commented
Dec 12, 2023
| @@ -178,7 +178,7 @@ func Build(ctx context.Context, | |||
| if err != nil { | |||
| return "", err | |||
| } | |||
| path, err := driverType.Build(ctx, printer, d.FixupKernel(kr), driverName, driverVer, env) | |||
| path, err := driverType.Build(ctx, printer, kr, driverName, driverVer, env) | |||
There was a problem hiding this comment.
Fixing up the kenrel is only useful when downloading.
FedeDP
commented
Dec 12, 2023
| _, err := exec.CommandContext(ctx, "/bin/bash", "-c", flatcarRelocateScript).Output() | ||
| out, err := exec.CommandContext(ctx, "/bin/bash", "-c", flatcarRelocateScript).Output() | ||
| if err != nil { | ||
| printer.DefaultText.Print(string(out)) |
There was a problem hiding this comment.
Print the error in case this step fails.
|
/hold |
It is indeed only useful to fixup the download url for given distro. Signed-off-by: Federico Di Pierro <[email protected]>
…on in printenv command. Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
fix/avoid_fixup_kernel_build
branch
from
74d7d97 to
69a6df7
Compare
|
/unhold |
leogr
approved these changes
Dec 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area library
What this PR does / why we need it:
Moreover, call
return f.generic.FixupKernel(kr)in flatcar FixupKernel.Which issue(s) this PR fixes:
Fixes #372
Special notes for your reviewer: