Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(cmd/driver): added more driver commands tests. #374

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 14, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

Implements tests for driver sub commands.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 14, 2023

/milestone v0.7.0

@poiana poiana added this to the v0.7.0 milestone Dec 14, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 14, 2023

/cc @alacuku

@FedeDP FedeDP force-pushed the new/drivers_cmd_test branch from 9bd0215 to c9bd9bb Compare December 14, 2023 10:14
@FedeDP FedeDP force-pushed the new/drivers_cmd_test branch from c9bd9bb to d669ae8 Compare December 14, 2023 10:23
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d72536c into main Dec 18, 2023
13 checks passed
@poiana poiana deleted the new/drivers_cmd_test branch December 18, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants