chore(internal): added engine version related tests. #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone v0.7.0 |
FedeDP
force-pushed
the
chore/follower_engine_ver_test
branch
from
5cb5a66 to
e4fa731
Compare
FedeDP
force-pushed
the
chore/follower_engine_ver_test
branch
2 times, most recently
from
1e1a138 to
16cab85
Compare
Signed-off-by: Federico Di Pierro <[email protected]> Co-authored-by: Lorenzo Susini <[email protected]>
FedeDP
force-pushed
the
chore/follower_engine_ver_test
branch
from
16cab85 to
f5646c6
Compare
|
/lgtm |
leogr
approved these changes
Jan 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr, maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area tests
What this PR does / why we need it:
This PR implements tests for Follower
checkRequirementsmethod.Which issue(s) this PR fixes:
Fixes #348
Special notes for your reviewer: