fix the empty result when the value of an output field contains a dash/slash + trim prefix with the timestamp and priority for the output #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
…h/slash + trim prefix with the timestamp and priority for the output Signed-off-by: Thomas Labarussias <[email protected]>
Issif
force-pushed
the
fix-search-dash-slash
branch
from
0732860 to
7ce682b
Compare
fjogeleit
approved these changes
Feb 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fjogeleit, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 4642ea92b0834542f2f53467b6d02bfd4e6bb3e1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
An user noticed empty result when we search for an output field value with a / or -. It was fixed for the tags and hostnames not for other fields.
Moreover, I added a regexp to remove for the output field the timestamp + priority, it's a redundant info in the event board. It also so save some space.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
These changes will imply to flush all data, the schema in redisearch must be replaced.