Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add NS and pod by default in loki output #1087

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

afreyermuth98
Copy link
Contributor

@afreyermuth98 afreyermuth98 commented Jan 6, 2025

What type of PR is this?
/kind design

Any specific area of the project related to this PR?
/area outputs

What this PR does / why we need it:
This PR puts the namespace and pod name as default fields in the loki output if they exist.
This is really useful to have a good setup at start and do not go into the extraLabels config as they are important keys to get.
Moreover, some of these labels are used by default by the dashboard, so it would be perfect if all the deployment (loki + dashboard) is working without extra configuration needed

@poiana
Copy link

poiana commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afreyermuth98
Once this PR has been reviewed and has the lgtm label, please assign issif for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from fjogeleit and leogr January 6, 2025 16:18
@poiana poiana added the size/XS label Jan 6, 2025
@afreyermuth98
Copy link
Contributor Author

If this PR is approved, I would add the modification of the grafana dashboard so it fits with k8s_pod_name because it's k8s_pod atm :)

Signed-off-by: afreyermuth98 <[email protected]>
@Issif Issif added this to the 2.31 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants