Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: mTLS client verification fails due to missing ClientCAs configuration in server side #666

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

jgmartinez
Copy link
Contributor

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area config

What this PR does / why we need it:

The PR fixes client mTLS verification from the server when using http_output.

Which issue(s) this PR fixes:

N/A

Fixes #508

Special notes for your reviewer:

Signed-off-by: Juan Gonzalez Martinez <[email protected]>
@poiana
Copy link

poiana commented Oct 12, 2023

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link

poiana commented Oct 12, 2023

Welcome @jgmartinez! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/XS label Oct 12, 2023
@Issif Issif added this to the 2.29.0 milestone Oct 12, 2023
Issif
Issif previously approved these changes Oct 12, 2023
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@poiana
Copy link

poiana commented Oct 12, 2023

LGTM label has been added.

Git tree hash: b94acc01f1a54385417d01ee947f15ddcfaeda1d

@CasperGN
Copy link

Hey @Issif,
Do we need to do something about the lint failing?

@Issif
Copy link
Member

Issif commented Oct 13, 2023

The logs says a go fmt should be run, can you test please

Signed-off-by: Juan Gonzalez Martinez <[email protected]>
@jgmartinez
Copy link
Contributor Author

jgmartinez commented Oct 13, 2023

Should be good now 😄 @Issif

@poiana poiana added the lgtm label Oct 13, 2023
@poiana
Copy link

poiana commented Oct 13, 2023

LGTM label has been added.

Git tree hash: 4a1c14ba52a434d969343cf2a55421aea6a6fd2f

@poiana
Copy link

poiana commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, jgmartinez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit df23e06 into falcosecurity:master Oct 13, 2023
@CasperGN
Copy link

Thanks a bunch for rapid response here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants