chore(ci): increase scap file threshold to 10% since it is a bit unst…

…able.

Also, still do the scap file threshold check even if unit tests check failed.

Signed-off-by: Federico Di Pierro <[email protected]>

.github/workflows/perf.yml

@@ -42,7 +42,7 @@ jobs:
           path: perf_*_diff.txt
           if-no-files-found: error
 
-      # Check will fail if there is any function slowed down >2%
+      # Check will fail if there is any function slowed down >2% (relative).
       # But we will always comment with the perf diff from master
       - name: Check > 2% threshold - unit tests
         id: compare_tests
@@ -53,10 +53,12 @@ jobs:
             exit 1
           fi
 
-      # Check will fail if there is any function slowed down >2%
+      # Check will fail if there is any function slowed down >10% (relative).
+      # Larger threshold since scap file perf seems much more unstable.
       # But we will always comment with the perf diff from master
-      - name: Check > 2% threshold - scap file
+      - name: Check > 10% threshold - scap file
         id: compare_scap
+        if: always() # Even if unit tests threshold check failed
         run: |
           echo "diff=perf_scap_diff.txt" >> $GITHUB_OUTPUT
           awk '{if (substr($2,RSTART+RLENGTH)+0 > 2) print }' perf_scap_diff.txt &> perf_diff_above_thresh.txt