Skip to content

Commit

Permalink
chore(libsinsp/test): use GTEST_SKIP to track disabled tests
Browse files Browse the repository at this point in the history
Signed-off-by: Roberto Scolaro <[email protected]>
  • Loading branch information
therealbobo committed Nov 28, 2024
1 parent a339e9d commit 12746a2
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions userspace/libsinsp/test/async_key_value_source.ut.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -335,16 +335,16 @@ TEST(async_key_value_source_test, look_key_delayed_async_callback) {

/**
* Ensure that "old" results are pruned
* This test usually fails like this when runned with sanitizers on arm64:
*
* pure virtual method called
* terminate called without an active exception
* Aborted (core dumped)
*
* Disabled until we can figure out how to fix it.
*/
#if !defined(__aarch64__)
TEST(async_key_value_source_test, prune_old_metadata) {
#if defined(__aarch64__)
GTEST_SKIP() << R"(This test usually fails like this when runned with sanitizers on arm64:
pure virtual method called
terminate called without an active exception
Aborted (core dumped)
Disabled until we can figure out how to fix it.)";
#endif
const uint64_t DELAY_MS = 0;
const uint64_t TTL_MS = 20;

Expand Down Expand Up @@ -380,7 +380,6 @@ TEST(async_key_value_source_test, prune_old_metadata) {
// fetch the first key should also return false.
ASSERT_FALSE(source.lookup(key1, response));
}
#endif

struct result {
uint64_t val = 0;
Expand Down

0 comments on commit 12746a2

Please sign in to comment.