fix(libsinsp): Add a CPU count check

In a scap file I have here, minfo->num_cpus is 0 when sinsp_filter_check_thread::extract_exectime is called. We handle this in debug builds with an ASSERT, but need to check for this in release builds as well. Bail out early if we either have no CPUs or if minfo is NULL. Signed-off-by: Gerald Combs <[email protected]>
falcosecurity · Dec 11, 2023 · 2174690 · 2174690
1 parent cc5cedd
commit 2174690
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/userspace/libsinsp/sinsp_filtercheck_thread.cpp b/userspace/libsinsp/sinsp_filtercheck_thread.cpp
@@ -366,6 +366,10 @@ uint64_t sinsp_filter_check_thread::extract_exectime(sinsp_evt *evt)
 		const scap_machine_info* minfo = m_inspector->get_machine_info();
 		ASSERT(minfo->num_cpus != 0);
 
+		if (minfo == NULL || minfo->num_cpus == 0) {
+			return res;
+		}
+
 		for(uint32_t j = 0; j < minfo->num_cpus; j++)
 		{
 			m_last_proc_switch_times.push_back(0);