refactor!(chisels): deprecate chisels

Signed-off-by: Roberto Scolaro <[email protected]>

.github/workflows/ci.yml

@@ -27,8 +27,6 @@ jobs:
             cmake_opts: -DBUILD_WARNINGS_AS_ERRORS=On -DBUILD_BPF=On -DUSE_BUNDLED_DEPS=False
           - name: bundled_deps
             cmake_opts: -DBUILD_WARNINGS_AS_ERRORS=On -DBUILD_BPF=On -DUSE_BUNDLED_DEPS=True
-          - name: system_deps_w_chisels
-            cmake_opts: -DBUILD_WARNINGS_AS_ERRORS=On -DBUILD_BPF=On -DUSE_BUNDLED_DEPS=False -DWITH_CHISEL=True
           - name: system_deps_minimal
             cmake_opts: -DBUILD_WARNINGS_AS_ERRORS=On -DUSE_BUNDLED_DEPS=False -DMINIMAL_BUILD=True
           - name: sanitizers
@@ -38,7 +36,7 @@ jobs:
     steps:
       - name: Install deps ⛓️
         run: |
-          apt update && apt install -y --no-install-recommends ca-certificates cmake build-essential git clang llvm pkg-config autoconf automake libtool libelf-dev wget libc-ares-dev libcurl4-openssl-dev libssl-dev libtbb-dev libjq-dev libjsoncpp-dev libgrpc++-dev protobuf-compiler-grpc libgtest-dev libprotobuf-dev liblua5.2-dev linux-headers-${{ matrix.arch }}
+          apt update && apt install -y --no-install-recommends ca-certificates cmake build-essential git clang llvm pkg-config autoconf automake libtool libelf-dev wget libc-ares-dev libcurl4-openssl-dev libssl-dev libtbb-dev libjq-dev libjsoncpp-dev libgrpc++-dev protobuf-compiler-grpc libgtest-dev libprotobuf-dev linux-headers-${{ matrix.arch }}
 
       - name: Checkout Libs ⤵️
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
@@ -103,7 +101,7 @@ jobs:
       - name: Install deps ⛓️
         run: |
           sudo apt update
-          sudo apt install -y --no-install-recommends ca-certificates cmake build-essential git clang llvm pkg-config autoconf automake libtool libelf-dev wget libc-ares-dev libcurl4-openssl-dev libssl-dev libre2-dev libtbb-dev libjq-dev libjsoncpp-dev libgrpc++-dev protobuf-compiler-grpc libgtest-dev libprotobuf-dev liblua5.2-dev linux-headers-$(uname -r)
+          sudo apt install -y --no-install-recommends ca-certificates cmake build-essential git clang llvm pkg-config autoconf automake libtool libelf-dev wget libc-ares-dev libcurl4-openssl-dev libssl-dev libre2-dev libtbb-dev libjq-dev libjsoncpp-dev libgrpc++-dev protobuf-compiler-grpc libgtest-dev libprotobuf-dev linux-headers-$(uname -r)
           sudo .github/install-deps.sh
 
       - name: Build and test 🏗️🧪
@@ -149,7 +147,7 @@ jobs:
       - name: Build and test 🏗️🧪
         run: |
           mkdir -p build
-          cd build && cmake -DUSE_BUNDLED_DEPS=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_MSVC_RUNTIME_LIBRARY=${{ matrix.crt }} -DCREATE_TEST_TARGETS=ON -DMINIMAL_BUILD=ON -DWITH_CHISEL=ON ..
+          cd build && cmake -DUSE_BUNDLED_DEPS=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_MSVC_RUNTIME_LIBRARY=${{ matrix.crt }} -DCREATE_TEST_TARGETS=ON -DMINIMAL_BUILD=ON ..
           cmake --build . --config Release && make run-unit-tests || libsinsp\test\Release\unit-test-libsinsp.exe
 
   build-shared-libs-macos-amd64:
@@ -238,8 +236,6 @@ jobs:
             cmake_opts: -DUSE_BUNDLED_DEPS=False
           - name: bundled_deps
             cmake_opts: -DUSE_BUNDLED_DEPS=True
-          - name: system_deps_w_chisels
-            cmake_opts: -DUSE_BUNDLED_DEPS=False -DWITH_CHISEL=True
           - name: asan
             cmake_opts: -DUSE_BUNDLED_DEPS=True -DCMAKE_C_FLAGS=-fsanitize=address -DCMAKE_CXX_FLAGS=-fsanitize=address
     runs-on: ubuntu-22.04
@@ -272,7 +268,6 @@ jobs:
             protobuf-compiler-grpc \
             libgtest-dev \
             libprotobuf-dev \
-            liblua5.2-dev \
             "linux-headers-$(uname -r)"
           sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-14 90
           sudo update-alternatives --install /usr/bin/llvm-strip llvm-strip /usr/bin/llvm-strip-14 90

.github/workflows/e2e_ci.yml

@@ -54,8 +54,7 @@ jobs:
             libgrpc++-dev \
             protobuf-compiler-grpc \
             libgtest-dev \
-            libprotobuf-dev \
-            liblua5.2-dev
+            libprotobuf-dev
           sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-14 90
           sudo update-alternatives --install /usr/bin/llvm-strip llvm-strip /usr/bin/llvm-strip-14 90
           sudo update-alternatives --install /usr/bin/llc llc /usr/bin/llc-14 90

CMakeLists.txt

@@ -110,6 +110,10 @@ option(WITH_CHISEL "Include chisel implementation" OFF)
 
 option(CREATE_TEST_TARGETS "Enable make-targets for unit testing" ON)
 
+if(WITH_CHISEL)
+	message(WARNING "chisels have been deprecated!")
+endif()
+
 if(CREATE_TEST_TARGETS)
 	include(gtest)
 endif()

README.md

@@ -33,9 +33,6 @@ plus chisels related code and common utilities.
   libscap and enriches them with machine state: moreover, it performs
   events filtering with rule evaluation through its internal rule engine.
   Finally, it manages outputs. 
-  * **chisels** are just little Lua scripts to analyze an event stream
-  and perform useful actions. In this subfolder, the backend code for
-  chisels support can be found.  
 * [_proposals/_](./proposals) unexpectedly contains the list of proposals.
 * [_cmake/modules/_](./cmake/modules) contains modules to build
 external dependencies, plus the libscap and libsinsp ones; consumers

cmake/modules/libsinsp.cmake

@@ -21,8 +21,6 @@ endif()
 
 option(USE_BUNDLED_DEPS "Enable bundled dependencies instead of using the system ones" ON)
 
-option(WITH_CHISEL "Include chisel implementation" OFF)
-
 if(DEFINED LIBSINSP_USER_AGENT)
 	add_definitions(-DLIBSINSP_USER_AGENT="${LIBSINSP_USER_AGENT}")
 endif()
@@ -90,11 +88,6 @@ install(DIRECTORY "${LIBS_DIR}/userspace/libsinsp" DESTINATION "${CMAKE_INSTALL_
 install(DIRECTORY "${LIBS_DIR}/userspace/async" DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/${LIBS_PACKAGE_NAME}"
 			COMPONENT "sinsp"
 			FILES_MATCHING PATTERN "*.h")
-if(WITH_CHISEL)
-	install(DIRECTORY "${LIBS_DIR}/userspace/chisel" DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/${LIBS_PACKAGE_NAME}"
-			COMPONENT "sinsp"
-			FILES_MATCHING PATTERN "*.h")
-endif()
 install(FILES ${PROJECT_BINARY_DIR}/libsinsp/libsinsp.pc DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)
 
 endif()

semgrep/absolute-include-paths.yaml

@@ -34,7 +34,6 @@ rules:
       - pattern-regex: ^#include "[^"]+"
       - pattern-not-regex: ^#include <(?!libsinsp/|libscap/|driver/).*
       - pattern-not-regex: ^#include "pkg/sentry.*
-      - pattern-not-regex: ^#include "lua.*
       - pattern-not-regex: ^#include "stdint.h"
       - pattern-not-regex: ^#include "json/json.h"
       - pattern-not-regex: ^#include "uthash.h"

test/e2e/containers/sinsp.Dockerfile

@@ -10,7 +10,6 @@ RUN apt-get update && \
     libjsoncpp1 \
     openssl \
     libre2-5 \
-    liblua5.2-0 \
     libtbb2
 
 COPY /sinsp-example /usr/local/bin/sinsp-example