fix(test/drivers): fixed sendmsgX_fail and socketcall_sendmsgX_fail t…

…ests. Signed-off-by: Federico Di Pierro <[email protected]>
falcosecurity · Apr 19, 2024 · 2af6126 · 2af6126
1 parent 7a182f9
commit 2af6126
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 29 deletions.
diff --git a/test/drivers/test_suites/syscall_exit_suite/sendmsg_x.cpp b/test/drivers/test_suites/syscall_exit_suite/sendmsg_x.cpp
@@ -175,23 +175,7 @@ TEST(SyscallExit, sendmsgX_fail)
 
 	evt_test->disable_capture();
 
-#ifdef __s390x__
-	/* For some reason this test is successful also with old bpf probe on s390x */
-	if(evt_test->is_modern_bpf_engine()	|| evt_test->is_bpf_engine())
-#else
-	if(evt_test->is_modern_bpf_engine())
-#endif
-	{
-		evt_test->assert_event_presence();
-	}
-	else
-	{
-		/* we need to rewrite the logic in old drivers to support this partial collection
-		 * right now we drop the entire event.
-		 */
-		evt_test->assert_event_absence();
-		GTEST_SKIP() << "[SENDMSG_X]: what we receive is correct but we need to reimplement it, see the code" << std::endl;
-	}
+	evt_test->assert_event_presence();
 
 	if(HasFatalFailure())
 	{

diff --git a/test/drivers/test_suites/syscall_exit_suite/socketcall_x.cpp b/test/drivers/test_suites/syscall_exit_suite/socketcall_x.cpp
@@ -1781,18 +1781,7 @@ TEST(SyscallExit, socketcall_sendmsgX_fail)
 
 	evt_test->disable_capture();
 
-	if(evt_test->is_modern_bpf_engine())
-	{
-		evt_test->assert_event_presence();
-	}
-	else
-	{
-		/* we need to rewrite the logic in old drivers to support this partial collection
-		 * right now we drop the entire event.
-		 */
-		evt_test->assert_event_absence();
-		GTEST_SKIP() << "[SENDMSG_X]: what we receive is correct but we need to reimplement it, see the code" << std::endl;
-	}
+	evt_test->assert_event_presence();
 
 	if(HasFatalFailure())
 	{