cleanup(libsinsp): remove some more misaligned accesses

Signed-off-by: Luca Guerra <[email protected]>
falcosecurity · Feb 22, 2024 · 2eaf8a1 · 2eaf8a1
1 parent d8bfc3c
commit 2eaf8a1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/userspace/libsinsp/fdinfo.h b/userspace/libsinsp/fdinfo.h
@@ -269,8 +269,8 @@ class SINSP_PUBLIC sinsp_fdinfo
 
 	inline void set_unix_info(uint8_t* packed_data)
 	{
-		m_sockinfo.m_unixinfo.m_fields.m_source = *(uint64_t *)(packed_data + 1);
-		m_sockinfo.m_unixinfo.m_fields.m_dest = *(uint64_t *)(packed_data + 9);
+		memcpy(&m_sockinfo.m_unixinfo.m_fields.m_source, packed_data + 1, sizeof(uint64_t));
+		memcpy(&m_sockinfo.m_unixinfo.m_fields.m_dest, packed_data + 9, sizeof(uint64_t));
 	}
 
 	/*!

diff --git a/userspace/libsinsp/sinsp_filtercheck_event.cpp b/userspace/libsinsp/sinsp_filtercheck_event.cpp
@@ -634,9 +634,7 @@ uint8_t* sinsp_filter_check_event::extract_error_count(sinsp_evt *evt, OUT uint3
 
 	if(pi != NULL)
 	{
-		ASSERT(pi->m_len == sizeof(uint64_t));
-
-		int64_t res = *(int64_t*)pi->m_val;
+		int64_t res = pi->as<int64_t>();
 		if(res < 0)
 		{
 			m_u32val = 1;
@@ -654,9 +652,7 @@ uint8_t* sinsp_filter_check_event::extract_error_count(sinsp_evt *evt, OUT uint3
 
 		if(pi != NULL)
 		{
-			ASSERT(pi->m_len == sizeof(uint64_t));
-
-			int64_t res = *(int64_t*)pi->m_val;
+			int64_t res = pi->as<int64_t>();
 			if(res < 0)
 			{
 				m_u32val = 1;
@@ -1202,9 +1198,7 @@ uint8_t* sinsp_filter_check_event::extract(sinsp_evt *evt, OUT uint32_t* len, bo
 
 			if(pi != NULL)
 			{
-				ASSERT(pi->m_len == sizeof(int64_t));
-
-				int64_t res = *(int64_t*)pi->m_val;
+				int64_t res = pi->as<int64_t>();
 
 				if(res >= 0)
 				{
@@ -1232,7 +1226,7 @@ uint8_t* sinsp_filter_check_event::extract(sinsp_evt *evt, OUT uint32_t* len, bo
 					pi = evt->get_param_by_name("fd");
 					if (pi)
 					{
-						int64_t res = *(int64_t*)pi->m_val;
+						int64_t res = pi->as<int64_t>();
 
 						if(res >= 0)
 						{