refactor(libsinsp): make base transform class pure virtual

Signed-off-by: Roberto Scolaro <[email protected]>
falcosecurity · Jan 8, 2025 · a955289 · a955289
1 parent c9f9e14
commit a955289
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.cpp b/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.cpp
@@ -16,11 +16,6 @@ limitations under the License.
 
 sinsp_filter_transformer::~sinsp_filter_transformer() {}
 
-bool sinsp_filter_transformer::transform_type(ppm_param_type& t, uint32_t& flags) const {
-	throw_unsupported_err(m_type);
-	return false;
-}
-
 bool sinsp_filter_transformer::string_transformer(std::vector<extract_value_t>& vec,
                                                   ppm_param_type t,
                                                   str_transformer_func_t f) {

diff --git a/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.h b/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.h
@@ -72,7 +72,7 @@ class sinsp_filter_transformer {
 
 	virtual ~sinsp_filter_transformer();
 
-	virtual bool transform_type(ppm_param_type& t, uint32_t& flags) const;
+	virtual bool transform_type(ppm_param_type& t, uint32_t& flags) const = 0;
 
 	virtual bool transform_values(std::vector<extract_value_t>& vals,
 	                              ppm_param_type& t,