refactor(userspace/libsinsp)!: remove legacy metadata clients for k8s and mesos #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
|
/milestone 0.14.0 |
|
Uh a small cleanup over here. 🤣 |
|
LGTM label has been added. Git tree hash: 0f568701a6ad36e2d0e1e5c95a5f8489ff014607
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
In coordination with @Andreagit97 and @alacuku with regards to falcosecurity/falco#2973 and falcosecurity/falco#2763, this PR introduces the breaking changes required to removing the metadata clients of k8s and mesos from our codebase.
This removes all the files related to the implementation of the clients, plus all the code related to them in other classes (such as
sinspand filterchecks). This preserves thek8s.*andmesos.*filterchecks classes, which will be cleaned up in a future PR due to some additional challenges specific to them.Which issue(s) this PR fixes:
Special notes for your reviewer:
Removing these 25k LOC gives me quite a trill and a totally expected feeling of joy.
Does this PR introduce a user-facing change?: