Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(userspace/libsinsp)!: drop support to protodecoders #1508

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area libsinsp

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Protodecoders are an ancient internal-only code instrument for implementing protocol decoders, which was introduced with the intention of supporting many. Over ~9 years, the only implementation we had for it is implementing the syslog.* fields. So, this proposes to remove protodecoders and implement those field in a simpler, more maintainable, and performant way (with no callback tangle).

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

refactor(userspace/libsinsp)!: drop support to protodecoders

@jasondellaluce jasondellaluce force-pushed the refactor/drop-protodecoders branch from 4fd1548 to e0c3bdd Compare November 24, 2023 11:34
@leogr leogr added this to the 0.14.0 milestone Nov 24, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 24, 2023

LGTM label has been added.

Git tree hash: 83a2d94bdcab4804645890dbfeaedefb7de0bfcb

@LucaGuerra
Copy link
Contributor

LucaGuerra commented Nov 24, 2023

I see that there is a ! in the name, what's the breaking change for the consumers of libs? I assume that it is the fact that it was technically possible to use protodecoders before (but nobody did).

Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link
Contributor

poiana commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d9a7511 into master Nov 24, 2023
21 checks passed
@poiana poiana deleted the refactor/drop-protodecoders branch November 24, 2023 15:59
@jasondellaluce
Copy link
Contributor Author

I see that there is a ! in the name, what's the breaking change for the consumers of libs? I assume that it is the fact that it was technically possible to use protodecoders before (but nobody did).

This. You never know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants