-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(userspace/libsinsp)!: drop support to protodecoders #1508
Conversation
Signed-off-by: Jason Dellaluce <[email protected]>
4fd1548
to
e0c3bdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 83a2d94bdcab4804645890dbfeaedefb7de0bfcb
|
I see that there is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This. You never know. |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Protodecoders are an ancient internal-only code instrument for implementing protocol decoders, which was introduced with the intention of supporting many. Over ~9 years, the only implementation we had for it is implementing the
syslog.*
fields. So, this proposes to remove protodecoders and implement those field in a simpler, more maintainable, and performant way (with no callback tangle).Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: