fix(userspace/libsinsp): make sure all destructors are invoked #1528
+24
−101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
I noticed we have a bunch of classes inheriting from others that haven't defined their destructor as virtual. Not doing so makes it very unpredictable to know which destructor is actually invoked at object disposal time. In general this causes segfaults or memory leaks. Looking at the code, I don't think this can be the cause of any time-growing memory leak in Falco, but my bet is that this eats some extra bytes when loading rules when not necessary. For other clients of the libs, this can potentially cause subtle issues.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: