Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Improve scap_engine_noop dependency #1590

Conversation

federico-sysdig
Copy link
Contributor

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build
/area libscap-engine-noop

Does this PR require a change in the driver versions?
no

What this PR does / why we need it:
Automates the include path seen by libraries that depend on library scap_engine_noop. Rather than repeating the path in each library the target scap_engine_noop brings now this property with itself.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@gnosek
Copy link
Contributor

gnosek commented Dec 17, 2023

/approve

@Andreagit97 Andreagit97 added this to the 0.15.0 milestone Dec 18, 2023
@federico-sysdig federico-sysdig force-pushed the build-improve-scap-engine-noop-dependency branch from 0b5d75f to c18d37d Compare December 22, 2023 14:36
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 18, 2024

LGTM label has been added.

Git tree hash: 21b198e392f92046907b681a44ff59cd093bcac3

@incertum
Copy link
Contributor

@gnosek could you re-approve? Thanks!

@poiana
Copy link
Contributor

poiana commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: federico-sysdig, gnosek, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a7c88dc into falcosecurity:master Jan 18, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants