Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing cstdint include to fix build on Alpine #1742

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Quarky9
Copy link
Contributor

@Quarky9 Quarky9 commented Mar 11, 2024

What type of PR is this?

/kind bug

/area libsinsp

Which issue(s) this PR fixes:

Fixes #1741

NONE

@poiana
Copy link
Contributor

poiana commented Mar 11, 2024

Welcome @Quarky9! It looks like this is your first PR to falcosecurity/libs 🎉

@FedeDP
Copy link
Contributor

FedeDP commented Mar 12, 2024

/kind bug
/area libsinsp

@poiana poiana added kind/bug Something isn't working area/libsinsp labels Mar 12, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Mar 12, 2024

Thanks for this PR! You need to sign commits using DCO: https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin.

After that, this LGTM! Thank you very much!

@Andreagit97 Andreagit97 added this to the 0.15.0 milestone Mar 12, 2024
@Andreagit97
Copy link
Member

Let's try it for 0.15.0

Signed-off-by: Stefan Reimer <stefan@zero-downtime.net>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 13, 2024

LGTM label has been added.

Git tree hash: fef3725ec66e98575de29616be5b705923ad9482

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, Quarky9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 2514b50 into falcosecurity:master Mar 13, 2024
41 checks passed
@FedeDP FedeDP mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to compile libinsp on Alpine 3.19 results in error: 'int64_t' has not been declared
4 participants