Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple definitions for scap_engine_handle #1889

Merged

Implement PR review's suggestions

f0346c0
Select commit
Loading
Failed to load commit list.
Merged

fix: multiple definitions for scap_engine_handle #1889

Implement PR review's suggestions
f0346c0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 14, 2024 in 0s

50.98% (+0.00%) compared to 2e87063

View this Pull Request on Codecov

50.98% (+0.00%) compared to 2e87063

Details

Codecov Report

Attention: Patch coverage is 13.51351% with 64 lines in your changes missing coverage. Please review.

Project coverage is 50.98%. Comparing base (2e87063) to head (f0346c0).
Report is 19 commits behind head on master.

Files Patch % Lines
userspace/libscap/engine/kmod/scap_kmod.c 13.88% 31 Missing ⚠️
userspace/libscap/engine/bpf/scap_bpf.c 0.00% 19 Missing ⚠️
userspace/libscap/engine/gvisor/gvisor.cpp 0.00% 9 Missing ⚠️
userspace/libscap/engine/savefile/scap_savefile.c 25.00% 3 Missing ⚠️
userspace/libscap/engine/noop/noop.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1889    +/-   ##
========================================
  Coverage   50.98%   50.98%            
========================================
  Files         310      310            
  Lines       39612    39612            
  Branches    17455    17707   +252     
========================================
+ Hits        20197    20198     +1     
- Misses      14338    14349    +11     
+ Partials     5077     5065    -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.