Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): avoid truncation while saving PR info in drivers ci. #1939

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 28, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 28, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Jun 28, 2024
@poiana poiana added the size/XS label Jun 28, 2024
Copy link

Perf diff from master - unit tests

     5.36%     -0.97%  [.] next
     2.33%     +0.84%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     0.11%     +0.78%  [.] scap_event_has_large_payload
     4.44%     +0.76%  [.] sinsp_thread_manager::find_thread
     4.20%     -0.72%  [.] sinsp_thread_manager::get_thread_ref
     3.47%     +0.69%  [.] sinsp_parser::process_event
     1.41%     +0.60%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.83%     -0.59%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     3.79%     +0.58%  [.] gzfile_read
    10.12%     +0.51%  [.] sinsp_parser::reset

Perf diff from master - scap file

     7.67%     +5.36%  [.] sinsp_evt_formatter::tostring_withformat
    11.66%     -4.29%  [.] sinsp_filter_check::tostring
     7.44%     +3.94%  [.] sinsp_thread_manager::find_thread
    11.58%     -2.68%  [.] sinsp_filter_check::apply_transformers
     7.76%     -2.29%  [.] sinsp_parser::process_event
     3.75%     +1.22%  [.] 0x00000000000a6f90
     3.90%     +1.14%  [.] sinsp_evt::get_param_as_str
    23.29%     +0.69%  [.] sinsp_filter_check::extract_nocache
     3.91%     -0.48%  [.] sinsp_filter_check::rawval_to_string
     3.89%     -0.40%  [.] sinsp_evt::get_param

Heap diff from master - unit tests

total runtime: -0.04s.
calls to allocation functions: -86 (2097/s)
temporary memory allocations: -38 (926/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: 0.00s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 2 (2/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@poiana poiana added size/S and removed size/XS labels Jun 28, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 372946e into master Jun 28, 2024
42 of 43 checks passed
@poiana poiana deleted the fix/avoid_truncation_x64_matrix branch June 28, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants