Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): run capture-related perf CI on tmpfs. #1975

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jul 25, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Try to make perf capture-related CI steps more stable.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

Perf diff from master - unit tests

     1.66%     -0.77%  [.] sinsp_evt::get_ts
     2.57%     +0.75%  [.] sinsp_thread_manager::get_thread_ref
     4.01%     -0.63%  [.] gzfile_read
     1.43%     +0.62%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     4.52%     -0.55%  [.] sinsp_evt::load_params
     2.34%     -0.47%  [.] scap_event_decode_params
     1.53%     -0.46%  [.] 0x00000000000e83a0
     0.86%     +0.46%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Identity, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >::find
     0.91%     +0.44%  [.] sinsp::fetch_next_event
     0.91%     -0.44%  [.] sinsp_fdtable::find

Perf diff from master - scap file

    12.16%     +6.11%  [.] sinsp_filter_check::extract_nocache
    15.35%     -5.74%  [.] sinsp_evt_formatter::tostring_withformat
     3.07%     +3.95%  [.] sinsp_evt::get_param_as_str
     9.16%     -3.77%  [.] next
     8.78%     -3.54%  [.] 0x00000000000a76b4
     3.07%     +1.88%  [.] sinsp_filter_check::get_field_info
     6.14%     -1.87%  [.] sinsp_filter_check::rawval_to_string
     6.13%     -1.87%  [.] sinsp_filter_check::get_transformed_field_info
     3.07%     +1.86%  [.] sinsp::next
     9.19%     -1.86%  [.] sinsp_filter_check_thread::extract_single

Heap diff from master - unit tests

total runtime: -0.09s.
calls to allocation functions: -917 (10188/s)
temporary memory allocations: -218 (2422/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: 0.00s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 0 (0/s)
peak heap memory consumption: -15B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

Perf diff from master - unit tests

     9.21%     +1.09%  [.] sinsp_parser::reset
     0.40%     +0.67%  [.] sinsp_evt::is_filtered_out
     1.69%     -0.61%  [.] sinsp_evt::get_ts
     0.76%     +0.61%  [.] libsinsp::events::is_unknown_event
     1.55%     -0.59%  [.] 0x00000000000e83a0
     8.18%     -0.56%  [.] sinsp::next
     2.90%     -0.52%  [.] sinsp_thread_manager::find_thread
     5.39%     +0.49%  [.] next
     0.93%     -0.48%  [.] sinsp_fdtable::find
     0.57%     -0.47%  [.] sinsp_container_info::~sinsp_container_info

Perf diff from master - scap file

    14.84%     -4.09%  [.] sinsp_evt_formatter::tostring_withformat
     2.95%     +3.53%  [.] libsinsp::runc::match_container_id
     8.89%     -2.06%  [.] sinsp_filter_check_thread::extract_single
     5.92%     -2.05%  [.] sinsp_filter_check::get_transformed_field_info
     5.93%     -1.98%  [.] sinsp_filter_check::rawval_to_string
     8.49%     -1.96%  [.] 0x00000000000a76b4
     2.79%     +1.89%  [.] sinsp_filter_check::tostring
     2.97%     +1.78%  [.] sinsp_evt::get_param_as_str
     2.97%     +1.67%  [.] sinsp_thread_manager::get_thread_ref
    11.76%     +1.67%  [.] sinsp_filter_check::extract_nocache

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -30B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@FedeDP FedeDP force-pushed the chore/run_capture_tmpfs branch from b4510b4 to 68d955c Compare July 25, 2024 08:34
@FedeDP FedeDP changed the title wip: chore(ci): run capture-related perf CI on tmpfs. chore(ci): run capture-related perf CI on tmpfs. Jul 25, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 25, 2024

This should hopefully help stabilize the perf related CI (mostly the perf tests on scap file!).
We can't gather correct results until the PR is merged in master since we are diffing from the master perf data :)
/cc @leogr @LucaGuerra

@poiana poiana requested a review from LucaGuerra July 25, 2024 08:38
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 25, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Jul 25, 2024
Copy link

Perf diff from master - unit tests

     9.11%     +1.02%  [.] sinsp_parser::reset
     1.67%     -0.77%  [.] sinsp_evt::get_ts
     5.33%     +0.77%  [.] next
     8.09%     -0.67%  [.] sinsp::next
     0.57%     +0.56%  [.] sinsp_utils::find_longest_matching_evt_param
     0.75%     +0.50%  [.] libsinsp::events::is_unknown_event
     4.54%     -0.47%  [.] sinsp_evt::load_params
     2.58%     +0.46%  [.] sinsp_thread_manager::get_thread_ref
     0.75%     +0.45%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     1.76%     -0.42%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>

Perf diff from master - scap file

     3.82%     +5.23%  [.] sinsp_filter_check::tostring
    11.61%     -2.97%  [.] 0x00000000000a76b4
    20.30%     -2.57%  [.] sinsp_evt_formatter::tostring_withformat
     8.10%     +2.52%  [.] sinsp_filter_check::get_transformed_field_info
     4.06%     +2.13%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
    16.08%     -1.88%  [.] sinsp_filter_check::extract_nocache
    12.16%     -1.61%  [.] sinsp_filter_check_thread::extract_single
     4.07%     +1.52%  [.] sinsp_parser::reset
     4.05%     +0.78%  [.] sinsp_filter_check::extract
     3.57%     +0.74%  [.] sinsp_split[abi:cxx11]

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -30B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.98%. Comparing base (5c80f0e) to head (68d955c).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1975    +/-   ##
========================================
  Coverage   50.98%   50.98%            
========================================
  Files         310      310            
  Lines       39612    39612            
  Branches    17535    17873   +338     
========================================
  Hits        20198    20198            
- Misses      14349    14363    +14     
+ Partials     5065     5051    -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 64fe187 into master Jul 25, 2024
43 of 46 checks passed
@poiana poiana deleted the chore/run_capture_tmpfs branch July 25, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants